Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error while loading iframe on mfe Unit Outline [FC-0062] #35828

Merged
merged 4 commits into from
Nov 15, 2024
Merged

fix: error while loading iframe on mfe Unit Outline [FC-0062] #35828

merged 4 commits into from
Nov 15, 2024

Conversation

rpenido
Copy link
Contributor

@rpenido rpenido commented Nov 12, 2024 •
edited
Loading

Description

On the Course unit page after merging the PR with new iframe for xblocks, an issue with infinite loading of the iframe appeared if the unit/xblock has tags. This PR solves the problem with the error that appeared. Addition and processing of the tagging functionality is planned in future PRs.
image

Testing instructions

  1. Switch the edx-platform to the branch of this PR
  2. Make sure the contentstore.new_studio_mfe.use_new_unit_page
  3. Run tutor dev exec cms openedx-assets build --env=dev to make sure the updated js is in place
  4. While on the master branch of authoring mfe, go to the Course unit page that has the added tags
  5. The course xblocks should be rendered inside the iframe

image

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 12, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 12, 2024 •
edited
Loading

Thanks for the pull request, @rpenido!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@rpenido rpenido mentioned this pull request Nov 12, 2024
Closed
PKulkoRaccoonGang
PKulkoRaccoonGang approved these changes Nov 12, 2024
View reviewed changes
Copy link

@PKulkoRaccoonGang PKulkoRaccoonGang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpenido thanks for the PR! I checked it locally, no error 💯

More information about the issue can be found here:
#35827

@rpenido rpenido marked this pull request as ready for review November 12, 2024 17:17
@rpenido
Copy link
Contributor Author

rpenido commented Nov 12, 2024 •
edited
Loading

Thanks @PKulkoRaccoonGang!
I updated the description according to your PR.

@pomegranited pomegranited added the FC Relates to an Axim Funded Contribution project label Nov 14, 2024
@pomegranited
Copy link
Contributor

@rpenido I'm not able to reproduce this issue anymore using latest master for edx-platform + frontend-app-authoring.. can you?

pomegranited
pomegranited approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Ah yes thank you @rpenido , rebuilding the static assets let me reproduce this issue in master, and verify this fix.

  • I tested this using the PR test instructions
  • I read through the code
  • I checked for accessibility issues by using my keyboard to navigate
  • Includes documentation -- left a nit re the added code comment.
  • User-facing strings are extracted for translation N/A

cms/static/js/views/pages/container_subviews.js Outdated Show resolved Hide resolved
@PKulkoRaccoonGang
Copy link

@rpenido Thanks!

@PKulkoRaccoonGang PKulkoRaccoonGang mentioned this pull request Nov 15, 2024
Draft
@rpenido rpenido changed the title fix: error while loading iframe on mfe Unit Outline fix: error while loading iframe on mfe Unit Outline [FC-0062] Nov 15, 2024
@ChrisChV ChrisChV enabled auto-merge (squash) November 15, 2024 17:53
@ChrisChV ChrisChV merged commit cb1e6ee into openedx:master Nov 15, 2024
50 checks passed
@ChrisChV ChrisChV deleted the rpenido/fal-3941-fix-tag-error-mfe-unit-outline branch November 15, 2024 17:54
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PKulkoRaccoonGang PKulkoRaccoonGang PKulkoRaccoonGang approved these changes

@ChrisChV ChrisChV ChrisChV approved these changes

@pomegranited pomegranited pomegranited approved these changes

Assignees
No one assigned
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rpenido @openedx-webhooks @pomegranited @PKulkoRaccoonGang @edx-pipeline-bot @ChrisChV